Re: Instead of DROP function use UPDATE pg_proc in an upgrade extension script

From: Vicky Vergara <vicky_vergara(at)hotmail(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Instead of DROP function use UPDATE pg_proc in an upgrade extension script
Date: 2017-04-04 13:07:41
Message-ID: MWHPR11MB1789A5C5285F0A15FFCA46378A0B0@MWHPR11MB1789.namprd11.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks,

you answered so fast that I know I am stepping into dangerous grounds.

But I would like to know more about your experience.

Any links that you can give me to read about the code and/or issues regarding the ip4r experience?

Vicky

________________________________
De: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Enviado: lunes, 3 de abril de 2017 11:28 p. m.
Para: Vicky Vergara
Cc: pgsql-hackers(at)postgresql(dot)org
Asunto: Re: [HACKERS] Instead of DROP function use UPDATE pg_proc in an upgrade extension script

>>>>> "Vicky" == Vicky Vergara <vicky_vergara(at)hotmail(dot)com> writes:

Vicky> UPDATE pg_proc SET [...]

Vicky> So, I want to know how "safe" can you consider the second
Vicky> method, and what kind of other objects do I need to test besides
Vicky> views.

Speaking from personal experience (I did this in the upgrade script for
ip4r, in a much simpler case than yours, and broke it badly), it's not
at all safe.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-04-04 13:11:37 Re: Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)
Previous Message Robert Haas 2017-04-04 13:07:12 Re: Parallel Bitmap Heap Scan - Prefetch pages are not updated properly