Re: [PATCH] Add an ldflags_sl meson build option

Updated patch with new description
________________________________
From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Sent: Tuesday, June 17, 2025 6:05 PM
To: Matt Smith (matts3) <matts3(at)cisco(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add an ldflags_sl meson build option

Hi,

On Mon, 16 Jun 2025 at 14:26, Matt Smith (matts3) <matts3(at)cisco(dot)com> wrote:
>
> Currently there doesn't seem to be a way to pass shared library-specific flags via a meson build option.
>
> This patch allows the existing ldflags_sl to be set via a build option.
>
> Patch created against the 17.4 release.

The patch looks correct.

+option('ldflags_sl', type: 'array', value: [],
+ description: 'Shared library ldflags')

nitpick: I would suggest using the same description from autoconf
build: 'extra linker flags for linking shared libraries only'.

--
Regards,
Nazir Bilal Yavuz
Microsoft