| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | "Matt Smith (matts3)" <matts3(at)cisco(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add an ldflags_sl meson build option |
| Date: | 2025-06-17 08:05:04 |
| Message-ID: | CAN55FZ3OzZhQ0nx3O+EyJSj8dmLotyYN9KSDDGRRpZhF7fcMGw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 16 Jun 2025 at 14:26, Matt Smith (matts3) <matts3(at)cisco(dot)com> wrote:
>
> Currently there doesn't seem to be a way to pass shared library-specific flags via a meson build option.
>
> This patch allows the existing ldflags_sl to be set via a build option.
>
> Patch created against the 17.4 release.
The patch looks correct.
+option('ldflags_sl', type: 'array', value: [],
+ description: 'Shared library ldflags')
nitpick: I would suggest using the same description from autoconf
build: 'extra linker flags for linking shared libraries only'.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-06-17 08:05:25 | Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close |
| Previous Message | Peter Eisentraut | 2025-06-17 07:59:26 | Re: pg_recvlogical cannot create slots with failover=true |