Re: str_casefold: fix typo in error message

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Sent: Tuesday, January 13, 2026 10:32
To: Steven Niu <niushiji(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: str_casefold: fix typo in error message

> On Jan 13, 2026, at 10:16, Steven Niu <niushiji(at)gmail(dot)com> wrote:
>
> From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
> Sent: Tuesday, January 13, 2026 10:09
> To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
> Subject: str_casefold: fix typo in error message
>
> Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial commit.Best regards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/
>
>
> Hi, Evan,
>
> I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(), so I think the change should be:
>
> - "lower()"),
> + "pg_newlocale_from_collation(()"),
>
> thought?

If you look at other functions in the file, there is a pattern for what it should be. In this patch, I just want to fix the error without breaking the pattern.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Yeah, I took a look at another function str_initcap() and you are correct.

Thanks,
Steven