| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Steven Niu <niushiji(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: str_casefold: fix typo in error message |
| Date: | 2026-01-13 02:32:41 |
| Message-ID: | 9157875F-1B6D-4166-BB44-1B59A85C14B1@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 13, 2026, at 10:16, Steven Niu <niushiji(at)gmail(dot)com> wrote:
>
> From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
> Sent: Tuesday, January 13, 2026 10:09
> To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
> Subject: str_casefold: fix typo in error message
>
> Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial commit.Best regards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/
>
>
> Hi, Evan,
>
> I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(), so I think the change should be:
>
> - "lower()"),
> + "pg_newlocale_from_collation(()"),
>
> thought?
If you look at other functions in the file, there is a pattern for what it should be. In this patch, I just want to fix the error without breaking the pattern.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2026-01-13 02:41:08 | Re: Row pattern recognition |
| Previous Message | David Rowley | 2026-01-13 02:32:21 | Re: Patch: dumping tables data in multiple chunks in pg_dump |