| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: file_fdw: Support multi-line HEADER option. |
| Date: | 2026-01-09 16:14:17 |
| Message-ID: | MEAPR01MB3031C2D7EC0BF805A894FE1EB682A@MEAPR01MB3031.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 09 Jan 2026 at 21:57, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:
> On Fri, Jan 9, 2026 at 7:22 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> > Thoughts?
>>
>> +1
>
> Thank you for the review!
>
>> Could you add this patch to the next Commitfest? It would be better to
>> commit it in v19 so that multi-line header support is delivered for
>> both COPY and file_fdw at the same time.
>
> Yeah, this feature is targeted for v19. I've added it to the next Commitfest.
> https://commitfest.postgresql.org/patch/6383/
>
A minor nitpick:
+ or a numeric line count for <literal>HEADER</literal>) to enable the desired
+ behavior.
s/numeric/non-negative integer/
More precise: excludes negative values & clarifies it's an integer.
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-01-09 16:17:12 | Re: improve performance of pg_dump with many sequences |
| Previous Message | David G. Johnston | 2026-01-09 16:12:24 | Re: docs: clarify ALTER TABLE behavior on partitioned tables |