| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: file_fdw: Support multi-line HEADER option. |
| Date: | 2026-01-15 07:23:46 |
| Message-ID: | CAOzEurSVZYuoAf57Lio49PrUvom_qSV9XPmhBiOB3GHwcwGOSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 10, 2026 at 1:14 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
> A minor nitpick:
>
> + or a numeric line count for <literal>HEADER</literal>) to enable the desired
> + behavior.
>
> s/numeric/non-negative integer/
>
> More precise: excludes negative values & clarifies it's an integer.
Thank you for the review! Agreed, and the revised patch is attached.
--
Best regards,
Shinya Kato
NTT OSS Center
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-file_fdw-Support-multi-line-HEADER-option.patch | application/octet-stream | 11.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-01-15 07:46:44 | Re: Fix gistkillitems & add regression test to microvacuum |
| Previous Message | Chao Li | 2026-01-15 07:20:14 | Re: [PATCH] psql: add \dcs to list all constraints |