| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: amcheck: support for GiST |
| Date: | 2026-01-12 10:19:38 |
| Message-ID: | MEAPR01MB30314D75A186503F840D474EB681A@MEAPR01MB3031.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Roman Khapov
On Mon, 12 Jan 2026 at 01:36, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
> Hi!
> Thanks for your review!
>
> We discussed offline about the patch, and I decided to make a review of it and fixes
> up to your comments.
>
Thank you for updating the patches.
>>
>> v2026-01-10-0001
>> ================
>>
>> 1.
>> I'm pretty sure access/heaptoast.h is not needed by verify_nbtree.c.
>>
>
> In fact this include is necessary because of line verify_common.c:236 which
> uses TOAST_INDEX_TARGET
>
Yeah, verify_common.c does require the header, but what I meant was that
verify_nbtree.c no longer needs it.
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index c1e24338361..426e23d2960 100644
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -23,7 +23,6 @@
*/
#include "postgres.h"
-#include "access/heaptoast.h"
#include "access/htup_details.h"
#include "access/nbtree.h"
#include "access/table.h"
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2026-01-12 10:21:13 | Re: global temporary table (GTT) - are there some ideas how to implement it? |
| Previous Message | Roman Khapov | 2026-01-12 10:05:53 | Re: Add ldapservice connection parameter |