| From: | Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Miłosz Bieniek <bieniek(dot)milosz(at)proton(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: amcheck: support for GiST |
| Date: | 2026-01-12 09:36:22 |
| Message-ID: | 9C2BD9F9-0D75-473C-B965-BE68FCB8EF41@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
Thanks for your review!
We discussed offline about the patch, and I decided to make a review of it and fixes
up to your comments.
>
> v2026-01-10-0001
> ================
>
> 1.
> I'm pretty sure access/heaptoast.h is not needed by verify_nbtree.c.
>
In fact this include is necessary because of line verify_common.c:236 which
uses TOAST_INDEX_TARGET
>
> v2026-01-10-0002
> ================
>
> blockNo is unsigned integer, so we should use %u in the format string.
>
> The same goes for parentblkno — it should also use %u.
>
Yes seems like there was misusage of format symbol.. I attached the v2026-01-12 with
fixed symbol. Thanks!
--
Best regards,
Roman Khapov
| Attachment | Content-Type | Size |
|---|---|---|
| v2026-01-12-0001-Move-normalize-tuple-logic-from-nbtcheck.patch | application/octet-stream | 9.8 KB |
| v2026-01-12-0002-Add-gist_index_check-function-to-verify-.patch | application/octet-stream | 33.6 KB |
| unknown_filename | text/plain | 2 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan Gonzalez V. | 2026-01-12 09:43:28 | Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode |
| Previous Message | Michael Banck | 2026-01-12 09:31:13 | Re: Maybe BF "timedout" failures are the client script's fault? |