Re: Transaction timeout

From: Japin Li <japinli(at)hotmail(dot)com>
To: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, 邱宇航 <iamqyh(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Transaction timeout
Date: 2024-01-31 09:27:06
Message-ID: ME3P282MB3166A01CE3BC1B8B9C846A75B67C2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Tue, 30 Jan 2024 at 14:22, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> On 26 Jan 2024, at 19:58, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>> Thanks for updating the patch. Here are some comments for v24.
>>
>> + <para>
>> + Terminate any session that spans longer than the specified amount of
>> + time in transaction. The limit applies both to explicit transactions
>> + (started with <command>BEGIN</command>) and to implicitly started
>> + transaction corresponding to single statement. But this limit is not
>> + applied to prepared transactions.
>> + If this value is specified without units, it is taken as milliseconds.
>> + A value of zero (the default) disables the timeout.
>> + </para>
>> The sentence "But this limit is not applied to prepared transactions" is redundant,
>> since we have a paragraph to describe this later.
> Fixed.
>>
>> +
>> + <para>
>> + If <varname>transaction_timeout</varname> is shorter than
>> + <varname>idle_in_transaction_session_timeout</varname> or <varname>statement_timeout</varname>
>> + <varname>transaction_timeout</varname> will invalidate longer timeout.
>> + </para>
>> +
>>
>> Since we are already try to disable the timeouts, should we try to disable
>> them even if they are equal.
>
> Well, we disable timeouts on equality. Fixed docs.
>
>>
>> +
>> + <para>
>> + Prepared transactions are not subject for this timeout.
>> + </para>
>>
>> Maybe wrap this with <note> is a good idea.
> Done.
>

Thanks for updating the patch. LGTM.

If there is no other objections, I'll change it to ready for committer
next Monday.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-01-31 09:31:29 Re: Improve WALRead() to suck data directly from WAL buffers when possible
Previous Message Bharath Rupireddy 2024-01-31 09:00:00 Re: Improve WALRead() to suck data directly from WAL buffers when possible