Re: [DOC] Introducing Quick Start Guide to PL/pgSQL and PL/Python Documentation

From: Japin Li <japinli(at)hotmail(dot)com>
To: Ishaan Adarsh <ishaanad9(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOC] Introducing Quick Start Guide to PL/pgSQL and PL/Python Documentation
Date: 2023-12-19 14:10:53
Message-ID: ME3P282MB31667752995127EDF49B7CDCB697A@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Tue, 19 Dec 2023 at 17:57, Ishaan Adarsh <ishaanad9(at)gmail(dot)com> wrote:
> I've addressed the points you raised:
>
> 1. *Missing `<filename>` Tag:*
> I reviewed the "Create the Makefile" section, and it seems that <filename>
> tags are appropriately used for filenames. If there's a specific instance
> where you observed a missing tag, please provide more details, and I'll
> ensure it's addressed.
>

Thanks.

> 2. *Use `CREATE EXTENSION` in "extension--version.sql":*
> Considering that there's already a CREATE EXTENSION step in the quick
> start guide, I can include a note in the general documentation to explain
> the rationale without repeating it in the individual script. What do you
> think?

Agreed.

--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2023-12-19 14:44:43 Re: Add new for_each macros for iterating over a List that do not require ListCell pointer
Previous Message Japin Li 2023-12-19 14:06:21 Re: Transaction timeout