From: | Ishaan Adarsh <ishaanad9(at)gmail(dot)com> |
---|---|
To: | Japin Li <japinli(at)hotmail(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [DOC] Introducing Quick Start Guide to PL/pgSQL and PL/Python Documentation |
Date: | 2023-12-19 09:57:24 |
Message-ID: | CA+oefZ6-Y8tuVs6W6=Rt5fZMtjR98VVEM+5SE2=9eaavYpO9Kw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I've addressed the points you raised:
1. *Missing `<filename>` Tag:*
I reviewed the "Create the Makefile" section, and it seems that <filename>
tags are appropriately used for filenames. If there's a specific instance
where you observed a missing tag, please provide more details, and I'll
ensure it's addressed.
2. *Use `CREATE EXTENSION` in "extension--version.sql":*
Considering that there's already a CREATE EXTENSION step in the quick
start guide, I can include a note in the general documentation to explain
the rationale without repeating it in the individual script. What do you
think?
--
Best regards,
Ishaan Adarsh
On Tue, Dec 19, 2023 at 12:28 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
> 1.
> It seems you miss <filename> tag in plpgsql "Create the Makefile":
>
> + <sect2 id="plpgsql-step4">
> + <title>Create the Makefile</title>
> +
> + <para>
> + Create a Makefile in the <filename>pg_plpgsql_ext</filename>
> directory with the following content:
> + </para>
>
> 2.
> We expected use CREATE EXTENSION to load the extension, should we add the
> following in extension--version.sql?
>
> -- complain if script is sourced in psql, rather than via CREATE EXTENSION
> \echo Use "CREATE EXTENSION pair" to load this file. \quit
>
> --
> Regrads,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2023-12-19 10:13:12 | Re: Simplify newNode() |
Previous Message | Drouvot, Bertrand | 2023-12-19 09:27:39 | Re: Add isCatalogRel in rmgrdesc |