RE: [19] CREATE SUBSCRIPTION ... SERVER

Hi,
Thanks for developing this great feature.

> Committed two patches.
The commit of 0004 patch added the `fdwconnection` column to the pg_foreign_data_wrapper catalog.
However, it seems the documentation is missing the definition for this column. The small patch attached adds the information for this column to catalog.sgml. There might be a better phrasing for the description text.

Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Jeff Davis <pgsql(at)j-davis(dot)com>
Sent: Thursday, March 19, 2026 4:07 AM
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>; Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>; Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>; Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>; Joe Conway <mail(at)joeconway(dot)com>; pgsql-hackers(at)postgresql(dot)org
Subject: Re: [19] CREATE SUBSCRIPTION ... SERVER

On Sat, 2026-03-14 at 15:55 -0700, Jeff Davis wrote:
> Attached series including patches to address Andres's and Amit's
> comments, too.

Committed two patches.

New patch 0004: fixes missing dependencies from the FDW to the connection function. There's a related pre-existing issue with the dependency from the FDW to the handler function, which I will post as a separate backportable bugfix.

I'd still like to find a good way to add pg_dump tests. The only idea I have now is to build the test function into core postgres (without pg_proc entry), which might be worthwhile.

Regards,
Jeff Davis