| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Eren Başak <eren(at)citusdata(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
| Date: | 2018-04-06 09:18:34 |
| Message-ID: | FFDDE5AE-B5A0-4992-915E-58A9FB662599@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 06 Apr 2018, at 04:49, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Apr 05, 2018 at 11:33:57PM +0200, Daniel Gustafsson wrote:
>> It seemed like a good idea at the time to indicate which part was submitted by
>> the user, but looking at it now the colon sign is a pretty clear indicator
>> already.
>
> Dropping the quotes is more consistent with other error messages. We
> don't bother about quoting things for example with system-related errors
> generated by strerror().
Yep, I completely agree. Attached are patches with the quotes removed and
rebased since Oids were taken etc.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactor-backend-signalling-code-v10.patch | application/octet-stream | 13.1 KB |
| 0002-Support-optional-message-in-backend-cancel-terminate-v10.patch | application/octet-stream | 20.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2018-04-06 09:25:59 | Re: Online enabling of checksums |
| Previous Message | Ernst-Georg Schmid | 2018-04-06 09:11:24 | AW: Get the name of the target Relation from Query struct? |