Re: [PATCH] test/ssl: rework the sslfiles Makefile target

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>
Subject: Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date: 2021-07-28 21:09:57
Message-ID: FBD68F12-C591-4589-AAC7-38F16AD226CE@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 28 Jul 2021, at 23:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jacob Champion <pchampion(at)vmware(dot)com> writes:

>> As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
>> happy.
>
> After reading the gmake docs about that, I'd have to say it's likely to be next
> door to unmaintainable.

Personally, I don’t think it’s that bad, but mileage varies. It’s obviously a
show-stopper if maintainers don’t feel comfortable with it.

> And, AFAICT, it's not in 3.80.

That however, is a very good point that I missed. I think it’s a good tool,
but probably not enough to bump the requirement.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-07-28 21:37:24 Re: Out-of-memory error reports in libpq
Previous Message Tom Lane 2021-07-28 21:02:54 Re: [PATCH] test/ssl: rework the sslfiles Makefile target