| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com> |
| Cc: | "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net> |
| Subject: | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Date: | 2021-07-28 21:02:54 |
| Message-ID: | 604960.1627506174@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jacob Champion <pchampion(at)vmware(dot)com> writes:
> On Wed, 2021-07-28 at 00:24 +0200, Daniel Gustafsson wrote:
>> GNU Make is already a requirement, I don't see this shifting the needle in any
>> direction.
Um ... the existing requirement is for gmake 3.80 or newer;
if you want to use newer features we'd have to have a discussion
about whether it's worthwhile to move that goalpost.
> As long as the .SECONDARYEXPANSION magic is clear enough to others, I'm
> happy.
After reading the gmake docs about that, I'd have to say it's
likely to be next door to unmaintainable. Do we really have
to be that cute? And, AFAICT, it's not in 3.80.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-07-28 21:09:57 | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Previous Message | Tom Lane | 2021-07-28 20:51:13 | Re: Out-of-memory error reports in libpq |