Re: GiST "choose subtree" support function to inline penalty

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: GiST "choose subtree" support function to inline penalty
Date: 2019-06-24 11:31:07
Message-ID: FA00CCE5-1B25-4C7D-A9F4-1A8DF9580D57@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

> 24 июня 2019 г., в 15:08, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net> написал(а):
>
> I'm looking at PostGIS geometry GiST index build times and try to optimize withing the current GiST framework. The function that shows a lot on my flame graphs is penalty.
>
> I spent weekend rewriting PostGIS penalty to be as fast as possible.
> (FYI https://github.com/postgis/postgis/pull/425/files)
>
> However I cannot get any meaningfully faster build time. Even when I strip it to "just return edge extension" index build time is the same.
>
> Is there a way to inline the penalty into above "choose subtree" loop somehow? That would also let us stop bit-fiddling floats to simulate a more complex choosing scheme.

Maybe we could just add new opclass function for choosing subtree?
I've created GSoC item for this[0].

Best regards, Andrey Borodin.

[0] https://wiki.postgresql.org/wiki/GSoC_2019#GiST_API_advancement_.282019.29

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2019-06-24 11:44:14 Re: Index Skip Scan
Previous Message David Rowley 2019-06-24 11:12:49 Re: Custom table AMs need to include heapam.h because of BulkInsertState