Re: Fix GROUP BY ALL handling of ORDER BY operator semantics

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix GROUP BY ALL handling of ORDER BY operator semantics
Date: 2026-07-15 08:01:50
Message-ID: F8D8CB8C-5628-4557-A694-1484D5A44340@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 14 Jul 2026, at 18:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:

>> Shouldn't those two queries yield the same result, or am I missing something
>> obvious?
>
> I might be undercaffeinated still, but I think those are both correct.

I think you are right, I confused myself on the cases where group by all is
rewritten into group by ().

FWIW, I had a look at what a revert of the commit would look like. The
original commit included some while-in-there docs/comment cleanups which carry
value on their own, so I think we should leave those in. The attached reverts
GROUP BY ALL but retains the cleanups. If we decide to revert, the v19 back
patch would need to remove the entry from the release notes as well, but I only
did a master revert patch for now.

--
Daniel Gustafsson

Attachment Content-Type Size
0001-Revert-Add-GROUP-BY-ALL.patch application/octet-stream 19.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2026-07-15 08:25:51 Re: [PATCH] Cover get_json_table_plan() with tests
Previous Message Dean Rasheed 2026-07-15 07:57:07 Re: Global temporary tables