| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | solai v <solai(dot)cdac(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Cover get_json_table_plan() with tests |
| Date: | 2026-07-15 08:25:51 |
| Message-ID: | CAJ7c6TNzXN2WxsHQB91D4_26ds+7yK5CpV694ib--ZzJsQa9vQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Solai,
Thanks for the feedback!
> I tested this patch on the current PostgreSQL master.The patch applied
> cleanly, but make check reported one regression test failure in
> sqljson_jsontable.
> Looking at regression.diffs, the failure comes from the newly added
> JSON_TABLE ... PLAN (...) statements. On my setup, they fail with:
> ERROR: syntax error at or near "PLAN"
> I also tried running the same JSON_TABLE ... PLAN (...) query manually
> in psql and got the same syntax error.
> Apart from that, I verified that the existing JSON_TABLE functionality
> still works as expected. I tested SELECT, EXPLAIN, EXPLAIN VERBOSE,
> and EXPLAIN ANALYZE, and they all produced the expected results.
> Is this patch expected to be applied on top of another patch that adds
> support for the JSON_TABLE PLAN (...) syntax?
The patch needs a rebase after today's commits. I will figure it out
and submit the updated version.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-07-15 08:42:35 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Daniel Gustafsson | 2026-07-15 08:01:50 | Re: Fix GROUP BY ALL handling of ORDER BY operator semantics |