| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org,Simon Riggs <simon(at)2ndquadrant(dot)com>,Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>,Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Time based lag tracking for logical replication |
| Date: | 2017-05-11 17:13:52 |
| Message-ID: | F6D57667-F161-499A-8B8F-579CBFFEC607@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On May 11, 2017 8:08:11 AM PDT, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>On 11 May 2017 at 14:12, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
>wrote:
>
>>> Attached patch is Petr's patch, slightly rebased with added pacing
>>> delay, similar to that used by HSFeedback.
>>>
>>
>> This looks reasonable. I would perhaps change:
>>> + /*
>>> + * Track lag no more than once per
>WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>>> + */
>>
>> to something like this for extra clarity:
>>> + /*
>>> + * Track lag no more than once per
>WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>>> + * to avoid flooding the lag tracker on busy servers.
>>> + */
>
>New patch, v3.
>
>Applying in 90 minutes, barring objections.
Could you please wait till tomorrow? I've bigger pending fixes for related code pending/being tested that I plan to push today. I'd also like to take a look before...
Thanks,
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-11 17:19:07 | Re: WITH clause in CREATE STATISTICS |
| Previous Message | Alvaro Herrera | 2017-05-11 17:08:38 | Re: WITH clause in CREATE STATISTICS |