| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: Time based lag tracking for logical replication |
| Date: | 2017-05-11 15:08:11 |
| Message-ID: | CANP8+jLw6CRJCytxx5hKuWa4zZhuiymsPpnRO_Rh+ad+juZfWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11 May 2017 at 14:12, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>> Attached patch is Petr's patch, slightly rebased with added pacing
>> delay, similar to that used by HSFeedback.
>>
>
> This looks reasonable. I would perhaps change:
>> + /*
>> + * Track lag no more than once per WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>> + */
>
> to something like this for extra clarity:
>> + /*
>> + * Track lag no more than once per WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>> + * to avoid flooding the lag tracker on busy servers.
>> + */
New patch, v3.
Applying in 90 minutes, barring objections.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| Add-support-for-time-based-lag-tracking-to-logical-170429.v3.patch | application/octet-stream | 12.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-05-11 15:12:33 | Re: Cached plans and statement generalization |
| Previous Message | Heikki Linnakangas | 2017-05-11 15:03:29 | eval_const_expresisions and ScalarArrayOpExpr |