Re: BUG #19714: pgcrypto pgp_sym_encrypt accepts nonnumeric s2k-mode as mode 0

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
Cc: shihao zhong <zhong950419(at)gmail(dot)com>, imchifan(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19714: pgcrypto pgp_sym_encrypt accepts nonnumeric s2k-mode as mode 0
Date: 2026-11-10 23:30:27
Message-ID: F592CD3C-C131-4082-94B6-485C672E6676@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 10 Nov 2026, at 06:18, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:

> I found no blocking issues. Looks good to me.

I agree that this looks overall good, but I did tweak it slightly in the
attached v2 to add range checking as well as some minor cleanup. I've yet to
do much more than test compile it, but it has the overall shape I was looking
for.

> This makes some inputs that work today fail, so I'd keep it to master.
> I can do back-branch versions if a committer wants it back-patched.

Still thinking about this, but off the cuff I'd prefer to backpatch.

--
Daniel Gustafsson

Attachment Content-Type Size
v2-0001-pgcrypto-reject-invalid-PGP-options.patch application/octet-stream 8.7 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2026-11-11 00:33:16 Re: BUG #19780: gtsvector_picksplit() reads uninitialized data when called with three entries
Previous Message David Rowley 2026-11-10 22:51:47 Re: BUG #19836: Backend crash with large hash partition modulus