Re: BUG #19714: pgcrypto pgp_sym_encrypt accepts nonnumeric s2k-mode as mode 0

Hi Shihao,

I reviewed v1 patches on master with assertions enabled. All
pgcrypto regression tests pass. Without 0001, all three new cases produce
ciphertext; with it, they raise the expected error.

I found no blocking issues. Looks good to me.

This makes some inputs that work today fail, so I'd keep it to master.
> I can do back-branch versions if a committer wants it back-patched.
>

I agree with keeping this on master. Back-patching would make previously
accepted malformed integer options fail across the PGP functions.

Thanks,
Sho

--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝