Re: MySQL-ism help patch for psql

From: David Christensen <david(at)endpoint(dot)com>
To: Florian Weimer <fweimer(at)bfk(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: MySQL-ism help patch for psql
Date: 2010-01-21 17:58:25
Message-ID: F4C187DC-3609-4204-B347-8B4A9856604B@endpoint.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Jan 21, 2010, at 11:48 AM, Florian Weimer wrote:

> * David Christensen:
>
>> Currently, a session will look like the following:
>>
>> machack:machack:5485=# show tables;
>> See:
>> \d
>> or \? for general help with psql commands
>> machack:machack:5485=#
>>
>> Said formatting looks like it could use some improvement, open to
>> suggestions, but something on a single line seems more useful.
>
> You should at least make clear that this is an error message due to an
> unsupported command. The output above looks broken. Something like
> this should be okay, I think:
>
> ERROR: unrecognized configuration parameter "tables"
> NOTICE: use \d to list tables, or \? for general help with psql
> commands
>
> ERROR: unrecognized configuration parameter "databases"
> NOTICE: use \l to list databases, or \? for general help with psql
> commands

That's a very good point as far as the visibility is concerned.
Should the error messages between the SHOW cases and the others be
consistent ("ERROR: unsupported command" or similar)? It's worth
noting that this is only in the psql client, but we could simulate the
ereport output from the server.

Regards,

David
--
David Christensen
End Point Corporation
david(at)endpoint(dot)com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-01-21 18:01:30 Re: MySQL-ism help patch for psql
Previous Message Tom Lane 2010-01-21 17:57:35 Re: Patch: regschema OID type