| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Christensen <david(at)endpoint(dot)com> |
| Cc: | Florian Weimer <fweimer(at)bfk(dot)de>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: MySQL-ism help patch for psql |
| Date: | 2010-01-21 18:02:28 |
| Message-ID: | 10968.1264096948@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Christensen <david(at)endpoint(dot)com> writes:
> Should the error messages between the SHOW cases and the others be
> consistent ("ERROR: unsupported command" or similar)? It's worth
> noting that this is only in the psql client, but we could simulate the
> ereport output from the server.
No. Not unless you want to simulate it to the point of honoring the
different verbosity settings, which would greatly expand the size of the
patch. We do not try to make the response to "help" look like an error
message, and I don't see the value of doing so here either.
(I think Florian's real problem with the proposed output is that it's
ugly, which I agree with --- the formatting is strange.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2010-01-21 18:04:19 | Re: Patch: regschema OID type |
| Previous Message | David E. Wheeler | 2010-01-21 18:02:14 | Re: Patch: regschema OID type |