Re: pg_stat_progress_cluster: do not default to CLUSTER

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Re: pg_stat_progress_cluster: do not default to CLUSTER
Date: 2026-09-09 08:20:24
Message-ID: F3F89D60-1FCB-4195-86C6-91B1A05BF6CF@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Sep 9, 2026, at 14:55, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Wed, Sep 9, 2026 at 1:03 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> So, repack_index_relid now describes the actual scan method but not if index ordering was requested. Maybe we should set PROGRESS_REPACK_INDEX_RELID in cluster_rel() rather than heapam_relation_copy_for_cluster()? Like in the attache diff.
>
> Thanks for the patch! LGTM.
>
>> it will translate any REPACK command into one of these other two.
>
> If we apply the proposed patch, at the same moment, personally I'd like to
> update this description of pg_stat_progress_cluster.command in the docs
> so that it clearly explains how REPACK is translated. How about:
>
> it will translate a REPACK command into CLUSTER if index ordering
> is requested,
> or VACUUM FULL otherwise.

Yes, that makes sense. I added integrated your suggestion into the patch.

PFA v2:

* 0001 - unchanged from v1-0001
* 0002 - the previous diff plus integrating Fujii-san suggested doc change

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v2-0001-Don-t-report-CLUSTER-for-a-redacted-progress-row.patch application/octet-stream 2.8 KB
v2-0002-Fix-command-reporting-for-REPACK-using-sequential.patch application/octet-stream 4.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-09-09 08:45:48 Re: Include schema-qualified names in publication error messages.
Previous Message yangboyu 2026-09-09 08:14:20 回复:logical decoding: skip unnecessary snapshot distribution.