| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: pg_stat_progress_cluster: do not default to CLUSTER |
| Date: | 2026-09-09 06:55:40 |
| Message-ID: | CAHGQGwEdyNCVrHsaEmu66DxunW8PiCj-Z3O3QRNudC3-uyRTzQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 9, 2026 at 1:03 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> So, repack_index_relid now describes the actual scan method but not if index ordering was requested. Maybe we should set PROGRESS_REPACK_INDEX_RELID in cluster_rel() rather than heapam_relation_copy_for_cluster()? Like in the attache diff.
Thanks for the patch! LGTM.
> it will translate any REPACK command into one of these other two.
If we apply the proposed patch, at the same moment, personally I'd like to
update this description of pg_stat_progress_cluster.command in the docs
so that it clearly explains how REPACK is translated. How about:
it will translate a REPACK command into CLUSTER if index ordering
is requested,
or VACUUM FULL otherwise.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-09-09 07:02:08 | Re: [PATCH] Allow bare library names for non-superuser LOAD |
| Previous Message | Peter Eisentraut | 2026-09-09 06:52:21 | Re: Use C11 alignas instead of palloc/malloc for alignment |