Re: [EXTERNAL] Support load balancing in libpq

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: Jelte Fennema <postgres(at)jeltef(dot)nl>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, mbanck(at)gmx(dot)net, aleksander(at)timescale(dot)com, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, andres(at)anarazel(dot)de
Subject: Re: [EXTERNAL] Support load balancing in libpq
Date: 2023-03-28 07:21:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 28 Mar 2023, at 09:16, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:

> "unlikely" macro is used in libpq_prng_init() in the patch. I wonder
> if the place is really 'hot' to use "unlikely" macro.

I don't think it is, I was thinking to rewrite as the below sketch:

if (pg_prng_strong_seed(&conn->prng_state)))

/* fallback seeding */

Daniel Gustafsson

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2023-03-28 07:28:40 Re: Moving forward with TDE
Previous Message Tatsuo Ishii 2023-03-28 07:16:28 Re: [EXTERNAL] Support load balancing in libpq