Re: [EXTERNAL] Support load balancing in libpq

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: daniel(at)yesql(dot)se
Cc: ishii(at)sraoss(dot)co(dot)jp, postgres(at)jeltef(dot)nl, stark(dot)cfm(at)gmail(dot)com, amborodin86(at)gmail(dot)com, jchampion(at)timescale(dot)com, orlovmg(at)gmail(dot)com, Jelte(dot)Fennema(at)microsoft(dot)com, mbanck(at)gmx(dot)net, aleksander(at)timescale(dot)com, pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de
Subject: Re: [EXTERNAL] Support load balancing in libpq
Date: 2023-03-28 07:36:18
Message-ID: 20230328.163618.2070165746316966097.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> "unlikely" macro is used in libpq_prng_init() in the patch. I wonder
>> if the place is really 'hot' to use "unlikely" macro.
>
> I don't think it is, I was thinking to rewrite as the below sketch:
>
> {
> if (pg_prng_strong_seed(&conn->prng_state)))
> return;
>
> /* fallback seeding */
> }

+1.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2023-03-28 07:37:07 Re: [EXTERNAL] Support load balancing in libpq
Previous Message Jelte Fennema 2023-03-28 07:33:27 Re: [EXTERNAL] Support load balancing in libpq