| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net> |
| Subject: | Re: Changing the state of data checksums in a running cluster |
| Date: | 2026-05-05 13:46:03 |
| Message-ID: | F00E9F4E-6042-4CBA-8C8C-0863D4154E50@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> While further testing this feature, I realized that ProcessSingleRelationFork()
> unconditionally called log_newpage_buffer() for every page of every relation
> during pg_enable_data_checksums(). This included unlogged relations,
> which by definition never generate WAL for data changes and are reset to their
> init fork on any recovery.
I've tested your patch, and also expanded the test you wrote a little with a
persistence change.
> Further testing this feature, I noticed that the cost_delay and cost_limit arguments
> to pg_enable_data_checksums() in practice have no effect.
Ugh, the API for updating the costs changed between when this code was written
and tested, and when it was committed (and since I was the one committing the
new API I really should've caught that). Thanks for the report and fix!
While hacking on your patches I realized that the regexes for finding page
verification failures in the logs were anchoring at the wrong point, the
attached 0003 fixes that.
Attached are editorialized versions of the patches, as well as my testfix, that
I'm planning to go ahead with.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| 0003-Fix-regex-searching-for-page-verification-failures-i.patch | application/octet-stream | 5.4 KB |
| 0002-Apply-data-checksum-worker-throttling-parameters.patch | application/octet-stream | 2.5 KB |
| 0001-Skip-WAL-for-unlogged-relations-during-online-checks.patch | application/octet-stream | 5.8 KB |
| unknown_filename | text/plain | 2 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SATYANARAYANA NARLAPURAM | 2026-05-05 14:24:07 | Re: Changing the state of data checksums in a running cluster |
| Previous Message | Aleksander Alekseev | 2026-05-05 13:06:21 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |