Re: Fix incorrect function comment of stringToNodeInternal

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix incorrect function comment of stringToNodeInternal
Date: 2025-09-25 07:46:13
Message-ID: ED8E9601-E342-4DAA-B6BD-38C70BDDC290@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 23 Sep 2025, at 09:50, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

> Again, found an incorrect function comment of stringToNodeInternal(). Wrong function name is put to the comment, I guess it was from a copy/paste error.

I think this is intentional, and the proposed change would not improve it. The
comment refers to the externally visible symbols stringToNodeWithLocations
(when enabled) and stringToNode The stringToNodeInternal function is just an
implementation detail of it, hence the comment further down on the actual
stringToNode() function being "Externally visible entry points".

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-09-25 07:53:29 Re: Incorrect logic in XLogNeedsFlush()
Previous Message Chao Li 2025-09-25 07:45:26 Re: Add support for specifying tables in pg_createsubscriber.