From: | wenjing zeng <wjzeng2012(at)gmail(dot)com> |
---|---|
To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
Date: | 2022-01-21 07:40:57 |
Message-ID: | ECF2E7F0-D237-44EA-971B-CB163B4EB457@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
HI
For patch create_table_storage-v1
1
+ALTER opt_column ColId SET STORAGE name
+opt_column_storage:
+ STORAGE ColId { $$ = $2; }
Are they both set to name or ColId? Although they are the same.
2 For ColumnDef new member storage_name, did you miss the function _copyColumnDef() _equalColumnDef()?
Regards
Wenjing
> 2021年12月27日 15:51,Teodor Sigaev <teodor(at)sigaev(dot)ru> 写道:
>
> Hi!
>
> Working on pluggable toaster (mostly, for JSONB improvements, see links below) I had found that STORAGE attribute on column is impossible to set in CREATE TABLE command but COMPRESS option is possible. It looks unreasonable. Suggested patch implements this possibility.
>
> [1] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfnyc-2021.pdf
> [2] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgvision-2021.pdf
> [3] http://www.sai.msu.su/~megera/postgres/talks/jsonb-pgconfonline-2021.pdf
> [4] http://www.sai.msu.su/~megera/postgres/talks/bytea-pgconfonline-2021.pdf
>
> PS I will propose pluggable toaster patch a bit later
> --
> Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
> WWW: http://www.sigaev.ru/<create_table_storage-v1.patch.gz>
From | Date | Subject | |
---|---|---|---|
Next Message | osumi.takamichi@fujitsu.com | 2022-01-21 07:45:06 | RE: Skipping logical replication transactions on subscriber side |
Previous Message | Andrey Borodin | 2022-01-21 07:02:36 | Re: MultiXact\SLRU buffers configuration |