| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Sugamoto Shinya <shinya34892(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions |
| Date: | 2025-11-10 14:43:52 |
| Message-ID: | E9F0329D-64B5-4D25-ACD1-0FBA1226CF39@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Nov 2025, at 10:06, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> On Nov 8, 2025, at 14:25, Sugamoto Shinya <shinya34892(at)gmail(dot)com> wrote:
>> This patch adds an error hint listing the valid encoding names,
>> so users can immediately see the supported options.
+1.
> I think hardcoding the encoding list is fragile. AFAIK, “base64url” was newly added just a couple of months ago.
>
> The list is defined in encode.c (search for enclist in the file), I guess we can add a function to return a string with a encoding names.
New encodings are added very infrequently, we can revisit this if that changes
but till then I think the simplicity of a hardcoded string is preferrable.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-11-10 14:45:21 | Re: should we have a fast-path planning for OLTP starjoins? |
| Previous Message | Daniel Gustafsson | 2025-11-10 14:21:13 | Re: Minor adjustment: Update the range of the commit_siblings parameter. |