Re: Minor adjustment: Update the range of the commit_siblings parameter.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: zengman <zengman(at)halodbtech(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Minor adjustment: Update the range of the commit_siblings parameter.
Date: 2025-11-10 14:21:13
Message-ID: 5E21FEDA-4769-4595-BBA9-28830A131F97@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 10 Nov 2025, at 14:53, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> On Nov 10, 2025, at 19:04, zengman <zengman(at)halodbtech(dot)com> wrote:

>> When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
>
> Yes, the definition in guc_parameters.dat shows min as 0 and max as 1000, so the fix is correct:

Agreed, and MinimumActiveBackends() has a fast-path to handle a value of zero
as well (in all supported back-branches).

We are currently in release freeze for the backbranches, but will commit this
once the tree opens up again backpatched to all supported branches.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-10 14:43:52 Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Previous Message Ilia Evdokimov 2025-11-10 14:20:42 Re: Use merge-based matching for MCVs in eqjoinsel