| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | zourenli <398740848(at)qq(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key() |
| Date: | 2025-12-29 22:33:18 |
| Message-ID: | E90C412D-A334-4913-BF39-FE255C67025B@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Dec 29, 2025, at 16:20, zourenli <398740848(at)qq(dot)com> wrote:
>
> Hi all,
>
> This is a trivial grammar fix for the comment of build_replindex_scan_key() function in replindex.c.
> Two missing indefinite articles 'a' are added to make the comment grammatically correct.
> No functional changes are involved.
>
> Patch is attached below.
>
> Thanks,
> zourenli
> <398740848(at)qq(dot)com>
>
>
>
> <v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>
Both fixes look unambiguously correct to me:
• “This is not generic routine” -> “This is not a generic routine”
• “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-29 22:55:29 | Re: lsyscache: free IndexAmRoutine objects returned by GetIndexAmRoutineByAmId() |
| Previous Message | Masahiko Sawada | 2025-12-29 22:14:34 | Re: Assertion failure in SnapBuildInitialSnapshot() |