Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: zourenli <398740848(at)qq(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH v1] replindex: Fix comment grammar in build_replindex_scan_key()
Date: 2026-01-05 05:55:55
Message-ID: CAA4eK1LocMpXac_XVikYOhPyC=nC01phLU+WXO+j9UNjsp-AfQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 30, 2025 at 4:04 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > On Dec 29, 2025, at 16:20, zourenli <398740848(at)qq(dot)com> wrote:
> >
> > <v1-0001-corrects-minor-grammatical-issues-in-comment-of-b.patch>
>
> Both fixes look unambiguously correct to me:
>
> • “This is not generic routine” -> “This is not a generic routine”
> • “used for REPLICA IDENTITY FULL table” -> “used for a REPLICA IDENTITY FULL table”
>

LGTM.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-01-05 06:01:02 Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions
Previous Message Amit Kapila 2026-01-05 05:51:29 Re: Wrong comment for ReplicationSlotCreate