| From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
|---|---|
| To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: For review: Server instrumentation patch |
| Date: | 2005-07-23 19:11:26 |
| Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E4AC94A6@ratbert.vale-housing.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: 23 July 2005 20:01
> To: Dave Page
> Cc: PostgreSQL-development
> Subject: Re: [HACKERS] For review: Server instrumentation patch
>
>
> This patch looks good. The only question I have is why you
> didn't want
> the pgport rename/unlink calls? We usually use them unless there is
> some reason not to.
<thinks...> Probably because this was written originally for 7.4 (as a
pgAdmin contrib module) and I'm guessing the pgport rename/unlink
weren't there at that time. I can't think of any reason not to use them
- do you want an updated patch or are you OK to tweak it when applying?
Regards, Dave.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-07-23 19:20:23 | Re: For review: Server instrumentation patch |
| Previous Message | Bruce Momjian | 2005-07-23 19:02:04 | regression failure on stats test |