Re: For review: Server instrumentation patch

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> > Sent: 23 July 2005 20:01
> > To: Dave Page
> > Cc: PostgreSQL-development
> > Subject: Re: [HACKERS] For review: Server instrumentation patch
> >
> >
> > This patch looks good. The only question I have is why you
> > didn't want
> > the pgport rename/unlink calls? We usually use them unless there is
> > some reason not to.
>
> <thinks...> Probably because this was written originally for 7.4 (as a
> pgAdmin contrib module) and I'm guessing the pgport rename/unlink
> weren't there at that time. I can't think of any reason not to use them
> - do you want an updated patch or are you OK to tweak it when applying?

No, I modified my version. Thanks.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073