From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
---|---|
To: | Amul Sul <sulamul(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Deduplicate code updating ControleFile's DBState. |
Date: | 2021-10-01 17:47:45 |
Message-ID: | E4089289-16C2-4419-A44D-BACB70806D54@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 9/22/21, 10:03 PM, "Amul Sul" <sulamul(at)gmail(dot)com> wrote:
> On Tue, Sep 21, 2021 at 9:43 PM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
>> Shouldn't we update the time in update_controlfile()?
>
> If you see the callers of update_controlfile() except for
> RewriteControlFile() no one else updates the timestamp before calling
> it, I am not sure if that is intentional or not. That was the one
> reason that was added in UpdateControlFile(). And another reason is
> that if you look at all the deleting lines followed by
> UpdateControlFile() & moving that to UpdateControlFile() wouldn't
> change anything drastically.
>
> IMO, anything going to change should update the timestamp as well,
> that could be a bug then.
I'm inclined to agree that anything that calls update_controlfile()
should update the timestamp. However, I wonder if the additional
calls to time() would have a noticeable impact.
Nathan
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2021-10-01 17:49:24 | Re: 2021-09 Commitfest |
Previous Message | Andrew Dunstan | 2021-10-01 17:43:23 | Re: 2021-09 Commitfest |