| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use proc_exit() in WalRcvWaitForStartPosition |
| Date: | 2026-04-12 23:33:02 |
| Message-ID: | E2D69547-B593-4899-95DE-1F46F7E14588@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Apr 10, 2026, at 22:17, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so I just changed “exit(0)” to “terminate”.
>
> Thanks for updating the patch!
>
> "termination instructs XXX to terminate" sounds a bit redundant. How
> about saying
> "to ereport(FATAL)" instead of “to terminate”?
>
> Regards,
>
>
> --
> Fujii Masao
Okay, yes, that was a bit redundant. I changed it to “to ereport(FATAL)” in v3.
After that change, the line went over 80 columns, so I also adjusted a few nearby lines to keep everything within the 80-column limit. There is no content change.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Use-proc_exit-in-WalRcvWaitForStartPosition.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-04-12 23:41:40 | Re: Small and unlikely overflow hazard in bms_next_member() |
| Previous Message | David Rowley | 2026-04-12 22:45:37 | Re: Use stack allocated StringInfoDatas, where possible (round 2) |