Re: Use proc_exit() in WalRcvWaitForStartPosition

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use proc_exit() in WalRcvWaitForStartPosition
Date: 2026-04-10 14:17:29
Message-ID: CAHGQGwHdqm5CCqiTR+Dpkr2maKCSVEPyoCOuB8WMHorDsGUeTw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so I just changed “exit(0)” to “terminate”.

Thanks for updating the patch!

"termination instructs XXX to terminate" sounds a bit redundant. How
about saying
"to ereport(FATAL)" instead of “to terminate”?

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-04-10 14:17:44 Documenting coding style
Previous Message Ayush Tiwari 2026-04-10 14:13:10 Re: [PATCH] Fix NULL dereference in pg_get_database_ddl()