pgsql: Fix errorhandling for PGP encryption

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix errorhandling for PGP encryption
Date: 2026-08-10 13:41:21
Message-ID: E1wtQFl-00000000y2S-1Ng0@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix errorhandling for PGP encryption

PGP encryption was using px_cipher_encrypt without checking if any
error was returned. When OpenSSL is running in FIPS mode, or when
the legacy provider hasn't been loaded, not all ciphers which are
supported by the PGP code are available and fail the init step in
px_cipher_encrypt. Since the PGP encryption failed to notice this
it XORed the non-encrypted block with the plaintext, effectively
disabling the encryption.

This was found due to a report of PGP encryption not respecting
the pgcrypto.builtin_crypto_enabled flag and allowing Blowfish
and DES. This however turned out to be a false positive, since
the PGP code only use ciphers from OpenSSL and not the built in
ciphers.

Bug: #19457
Reported-by: Shishir Sharma <ansh01072001(at)gmail(dot)com>
Reviewed-by: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/19457-4bab15c17aea36c7@postgresql.org
Security: CVE-2026-14663
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0ecee6de9afec143a4766a72df0d3018a06d662
Author: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>

Modified Files
--------------
contrib/pgcrypto/expected/pgp-decrypt_1.out | 2 +-
contrib/pgcrypto/expected/pgp-encrypt_1.out | 192 +++++++++++++++++++++
contrib/pgcrypto/expected/pgp-pubkey-decrypt_1.out | 2 +-
contrib/pgcrypto/pgp-cfb.c | 8 +-
doc/src/sgml/pgcrypto.sgml | 5 +
5 files changed, 206 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2026-08-10 13:41:22 pgsql: Return nulls honestly in aggregate "combine" functions.
Previous Message Noah Misch 2026-08-10 13:41:20 pgsql: Fix pg_trgm's picksplit function with all-true datums