pgsql: Fix pg_trgm's picksplit function with all-true datums

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pg_trgm's picksplit function with all-true datums
Date: 2026-08-10 13:41:20
Message-ID: E1wtQFk-00000000y18-0eu6@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_trgm's picksplit function with all-true datums

The CACHESIGN.sign field is a BITVECP, not a TRGM, so you should not
use GETSIGN() on it. You don't get a compiler warning because the
GETSIGN() macro includes a cast. It resulted in a bogus read beyond
end of buffer, which would cause bad split decisions or a crash if
you're very unlucky.

Reported-by: Mehmet D. INCE <mehmet(at)mehmetince(dot)net>
Backpatch-through: 14
Security: CVE-2026-14678

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/66c2dbb20445195f92225708a930112ee9e96bf4
Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>

Modified Files
--------------
contrib/pg_trgm/trgm_gist.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2026-08-10 13:41:21 pgsql: Replace fixed-size, too-short array with a palloc'd one.
Previous Message Noah Misch 2026-08-10 13:41:19 pgsql: pg_dump: avoid assuming how long pg_proc.protrftypes can be.