pgsql: Update GROUP BY ALL comments about window functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Update GROUP BY ALL comments about window functions
Date: 2026-07-07 06:54:17
Message-ID: E1wgzhC-001hqM-07@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Update GROUP BY ALL comments about window functions

When GROUP BY ALL was added in commit ef38a4d9756, the SQL standard
working draft was silent on what to do with window functions. This
has now been fixed in the SQL standard working draft. Update the
documentation and code comments about that.

Also make the documentation more specific that we are only talking
about aggregate functions referring to the same query level, which is
another thing that has been made more precise in the SQL standard
working draft since.

The PostgreSQL implementation was already doing the right thing for
both aspects, so no functionality changes.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/CAHM0NXjz0kDwtzoe-fnHAqPB1qA8_VJN0XAmCgUZ%2BiPnvP5LbA%40mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7f0998f87b08e325ab65b1355464a1430042b9aa

Modified Files
--------------
doc/src/sgml/queries.sgml | 2 +-
doc/src/sgml/ref/select.sgml | 3 ++-
src/backend/parser/parse_clause.c | 4 +---
3 files changed, 4 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2026-07-07 09:43:13 pgsql: postgres_fdw: Report ANALYZE to pgstats after importing statisti
Previous Message Amit Langote 2026-07-06 23:46:32 pgsql: Enforce RETURNING typmod on SQL/JSON DEFAULT behavior expression