pgsql: Fix 051_effective_wal_level.pl on builds without injection point

From: Masahiko Sawada <msawada(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix 051_effective_wal_level.pl on builds without injection point
Date: 2026-05-27 22:53:06
Message-ID: E1wSN7a-001PTq-0I@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix 051_effective_wal_level.pl on builds without injection points.

Commit 2af1dc89282 placed the new "logical decoding disabled after
REPACK (CONCURRENTLY)" check at the end of
051_effective_wal_level.pl. That placement assumed the logical slot
"test_slot" no longer existed when the check ran, but the assumption
only holds on builds with injection points: the earlier
injection-point-driven tests drop "test_slot" as a side effect, while
on builds without injection points the slot persists. When
"test_slot" still exists, logical decoding remains enabled and the new
check fails on those buildfarm members.

Move the REPACK test earlier in the script, ensuring that the test
starts with logical decoding disabled.

Reviewed-by: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Discussion: https://postgr.es/m/CAD21AoBmdmBQ-+Jga+jSKKq5OPGEP1pEjSJfRPT6MCwVHLD6og@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/47ad2233fad4335fdd866c8ad55941706ae1661d

Modified Files
--------------
src/test/recovery/t/051_effective_wal_level.pl | 28 +++++++++++++-------------
1 file changed, 14 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2026-05-27 22:55:11 Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
Previous Message Alexander Korotkov 2026-05-27 20:08:41 Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)