| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY) |
| Date: | 2026-05-27 20:08:41 |
| Message-ID: | CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi!
On Wed, May 27, 2026 at 9:14 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> Disable logical decoding after REPACK (CONCURRENTLY)
>
> REPACK (CONCURRENTLY) uses a temporary logical replication slot, which
> is dropped once done, but it wasn't calling RequestDisableLogicalDecoding(),
> leaving effective_wal_level stuck at 'logical'.
>
> Fix by adding a Boolean flag to ReplicationSlotDropAcquired() to have it
> request to disable logical decoding, and passing it as true on REPACK.
> Other callers of that function preserve their existing behavior.
>
> Author: Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>
> Reviewed-by: shveta malik <shveta(dot)malik(at)gmail(dot)com>
> Discussion: https://postgr.es/m/CA+UBfaktds57dw2M8BEv_kS-=ixph3w+3MxKixtaDQMi_k7Ybg@mail.gmail.com
This seams to cause buildfarm failures, for instance
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2026-05-27%2018%3A25%3A00
------
Regards,
Alexander Korotkov
Supabase
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-05-27 22:53:06 | pgsql: Fix 051_effective_wal_level.pl on builds without injection point |
| Previous Message | Álvaro Herrera | 2026-05-27 18:14:40 | pgsql: Disable logical decoding after REPACK (CONCURRENTLY) |