pgsql: Add missing initialization

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing initialization
Date: 2026-04-16 20:31:35
Message-ID: E1wDTN8-001Iof-1K@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing initialization

The backend running REPACK can check DecodingWorkerShared->initialized
before the worker could have the chance to initialize it, possibly
leading to wrong behavior.

While at it, remove DecodingWorkerShared->worker_dsm_segment, because
that doesn't actually need to be in shared memory; a simple local-memory
global variable is enough.

Oversights in commit 28d534e2ae0a.

Author: Antonin Houska <ah(at)cybertec(dot)at>
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://postgr.es/m/18181295-8375-4789-ad32-269d78d6001e@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/05c401d5786a05ea630e884ffa492aa01683d15b

Modified Files
--------------
src/backend/commands/repack.c | 1 +
src/backend/commands/repack_worker.c | 7 +++++--
src/include/commands/repack_internal.h | 1 -
3 files changed, 6 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2026-04-16 20:57:53 pgsql: Make psql DETAIL line test unconditionally optional.
Previous Message Jeff Davis 2026-04-16 18:42:15 Re: pgsql: Perform provider-specific initialization in new functions.