Re: pgsql: Perform provider-specific initialization in new functions.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Perform provider-specific initialization in new functions.
Date: 2026-04-16 18:42:15
Message-ID: 2153399092d446bc1137eee5f70ad7af70e9039e.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, 2026-04-13 at 14:08 -0700, Jeff Davis wrote:

> That
> has two benefits:
>
> 1. Fixes your issue, because C_COLLATION_OID is always available.
> 2. Faster than a default collation based on libc or ICU.

I didn't detect any meaningful improvement here, probably because most
catalog cache lookups use columns with type NAME not TEXT.

But this still seems like a good idea on the grounds that, if we are
choosing an arbitrary deterministic collation for some internal
purpose, we should consistently choose the simplest and fastest one.

>
> I don't see a reason to backport this, but if someone else does then
> I
> could be convinced.

I plan to commit this soon.

I don't plan to backport unless someone sees a reason that it should be
backported (and if so, how far?).

Regards,
Jeff Davis

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2026-04-16 20:31:35 pgsql: Add missing initialization
Previous Message Bruce Momjian 2026-04-16 16:46:03 pgsql: doc PG 19 relnotes: add author and move items