| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_plan_advice: Always install pg_plan_advice.h, and in the righ |
| Date: | 2026-03-17 17:43:46 |
| Message-ID: | E1w2YSH-000CH7-2w@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_plan_advice: Always install pg_plan_advice.h, and in the right place
The Makefile failed to set HEADERS_pg_plan_advice, so the header wasn't
installed. Fixing that reveals another problem: since this is just a
loadable module, not an extension, the header file is installed into
$(includedir_server)/contrib rather than $(includedir_server)/extension.
While we have no existing cases of installing header files there, it
appears to be the intent of pgxs.mk. However, this is inconsistent with
meson.build, which was using dir_include_extension. Changing that to
dir_include_server / 'contrib' makes the install locations consistent
across the two builds.
Author: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Discussion: http://postgr.es/m/CAN4CZFP6NOjv__4Mx+iQD8StdpbHvzDAatEQn2n15UKJ=MySSQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/59dcc19b397f69a3654d39bae5a13f1659d922d8
Modified Files
--------------
contrib/pg_plan_advice/Makefile | 2 ++
contrib/pg_plan_advice/meson.build | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-03-17 18:15:40 | pgsql: Test pg_plan_advice using a new test_plan_advice module. |
| Previous Message | Nathan Bossart | 2026-03-17 16:33:35 | pgsql: pg_dump: Simplify query for retrieving attribute statistics. |