pgsql: pg_dump: Simplify query for retrieving attribute statistics.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dump: Simplify query for retrieving attribute statistics.
Date: 2026-03-17 16:33:35
Message-ID: E1w2XMM-000BlE-2T@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Simplify query for retrieving attribute statistics.

This query fetches information from pg_stats, which did not return
table OIDs until recent commit 3b88e50d6c. Because of this, we had
to cart around arrays of schema and table names, and we needed an
extra filter clause to hopefully convince the planner to use the
correct index. With the introduction of pg_stats.tableid, we can
instead just use an array of OIDs, and we no longer need the extra
filter clause hack.

Author: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Reviewed-by: Sami Imseih <samimseih(at)gmail(dot)com>
Discussion: https://postgr.es/m/CADkLM%3DcoCVy92QkVUUTLdo5eO2bMDtwMrzRn_8miAhX%2BuPaqXg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b5ba0c4ca5244d0ed589f67baf0204957886e6b

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 65 ++++++++++++++++++++++++++++++++++++++---------
src/bin/pg_dump/pg_dump.h | 1 +
2 files changed, 54 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-03-17 17:43:46 pgsql: pg_plan_advice: Always install pg_plan_advice.h, and in the righ
Previous Message Peter Eisentraut 2026-03-17 15:52:43 pgsql: Hardcode typeof_unqual to __typeof_unqual__ for clang